UYANDIRAN, A. PHP Library for Graph Generation [online]. Brno: Vysoké učení technické v Brně. Fakulta strojního inženýrství. 2020.

Posudek vedoucího

Roupec, Jan

The main goal of this thesis is to create an object library for graph generation in php language. Output in svg format is required and support for commonly used chart types is assumed. The results of the work will be used in a research project supported by Technology Agency of the Czech Republic. Unfortunately, the graduate worked in difficult conditions, due to the pandemic, all communication took place at a distance using electronic means of communication and he even could not use university equipment for development and testing. Even under these difficult conditions, all the points required by the assignment were met. The created library is functional and usable for the given purpose. The possibilities of generating graphs are sufficiently universal. I highly appreciate the possibilities and appearance of graphs of discrete values. The theoretical part could be elaborated in more detail, but due to the above mentioned conditions, the result is satisfactory. In this thesis, the author has demonstrated sufficient theoretical knowledge, practical ability to independently apply that knowledge and good programming skills. I recommend the thesis for defense.

Posudek oponenta

Heriban, Pavel

The master’s thesis titled "PHP Library for Graphical Implementation of Data" is divided into seven chapters and contains 49 pages. The text of the thesis is very brief, most of the content is created by code listings. The formulations used are rather popular than professional. The meaning of some sentences remained misunderstood by the opponent. This may be due to missing or improperly used words. There are also several punctuation errors. Theoretical chapters contain a number of inaccuracies, eg. Novell Netware server is not a web server. There is also a number of shortcomings and errors in the published code. Method roundn() (on page 10) cannot do the expected. Maybe because it is not used in the following code and the shortcoming cannot be detected by the author. Some methods defined in the mysvc class are also defined in the following code as embedded functions instead of being called directly, eg. randomcolor() method defined on page 10 and the same embedded function on page 35, ifd() method defined on page 11 and embedded function on page 24). According to the php code, it might seem that the author has some shortcomings in mathematics too. Otherwise, he would not defined ifd() method (page 11) by 18 lines of code but by only one:     return array($a[1]+$x, $a[0]-$y); Similar mathematical problem occurs in the code of radarchart() method on pages 31 and 32. The proper and usable positive and negative signs of results of sin() and cos() functions of an angle were firstly destroyed by abs() function (lines 546, 547) to be subsequently determined by value of the same angle in four blocks of the if-else command (552, 565, 575, 585). Mistyped 3*M_PI/4 instead of 3*M_PI/2 on line 585 has no effect on the result. There is another error in the code of radarchart() method. It is visible on figure 14 (page 34) too. All colors used in the rectangles before the captions are the same as the color used to draw the last radar chart. One error occurs in all graphs generated by the published code, the missing closing tag . Despite the shortcomings mentioned above, I recommend the thesis for the defense.

eVSKP id 128317